hoelee/server
1
0
Fork 0
Code Issues 76 Pull Requests 13 Actions Packages Projects Releases Wiki Activity

Sub host options: ala whitecolor #82

Closed
gojisystems wants to merge 7 commits from master into master
pull from: master
merge into: :master
Conversation 6 Commits 7 Files Changed 10
+3948 -1264
gojisystems commented 2018-03-01 18:23:56 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Taken from @whitecolor 's work on Express version of server. Applied to new server, including working tests (also taken from @whitecolor). Main modification occurred to GetClientIdFromHostname function.

Taken from @whitecolor 's work on Express version of server. Applied to new server, including working tests (also taken from @whitecolor). Main modification occurred to GetClientIdFromHostname function.
gojisystems commented 2018-03-01 21:49:15 +00:00 (Migrated from github.com)
Copy Link
Copy Source

fixed travis build bugs/tests. now allow for single string sub-hosts.
--sub-host nested.sub works as well as
--sub-host nested --sub-host sub

fixed travis build bugs/tests. now allow for single string sub-hosts. `--sub-host nested.sub` works as well as `--sub-host nested --sub-host sub`
defunctzombie commented 2018-04-02 00:35:10 +00:00 (Migrated from github.com)
Copy Link
Copy Source

What is a "sub-host"? Would it be easier if the subdomain parsing just looked at items before the first period? Or are there other features preventing that?

What is a "sub-host"? Would it be easier if the subdomain parsing just looked at items before the first period? Or are there other features preventing that?
defunctzombie commented 2018-04-02 00:36:22 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Specifically; how do these approaches compare to https://github.com/localtunnel/server/pull/25

Specifically; how do these approaches compare to https://github.com/localtunnel/server/pull/25
defunctzombie commented 2018-04-02 00:36:51 +00:00 (Migrated from github.com)
Copy Link
Copy Source

And this one https://github.com/localtunnel/server/pull/24

And this one https://github.com/localtunnel/server/pull/24
defunctzombie (Migrated from github.com) reviewed 2018-04-02 02:31:36 +00:00
README.md
@@ -2,3 +2,3 @@
[![Build Status](https://travis-ci.org/localtunnel/server.svg?branch=master)](https://travis-ci.org/localtunnel/server)
[![Build Status](https://travis-ci.org/gojisystems/gojiconnect-server.svg?branch=master)](https://travis-ci.org/gojisystems/gojiconnect-server)
defunctzombie (Migrated from github.com) commented 2018-04-02 02:31:36 +00:00
Copy Link
Copy Source

When making a PR please don't alter files in this way as such a change can't be merged into this repo as-is. This is great for your repo but for the PR it should be removed.

When making a PR please don't alter files in this way as such a change can't be merged into this repo as-is. This is great for your repo but for the PR it should be removed.
defunctzombie commented 2018-04-02 02:58:58 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Done via 86dce49dd1

Thank you for your input on this feature!

Done via 86dce49dd1d40a64a2f121ff3aa271719417810f Thank you for your input on this feature!

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
defunctzombie
Labels
Clear labels
bug
duplicate
enhancement
invalid
question
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
hoelee (Mr hoelee)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: hoelee/server#82