Allows dash characters in subdomains #47

Closed
zackslash wants to merge 2 commits from master into master
2 changed files with 17 additions and 2 deletions
+1 -1
View File
@@ -221,7 +221,7 @@ module.exports = function(opt) {
var req_id = req.params.req_id;
// limit requested hostnames to 63 characters
if (! /^[a-z0-9]{4,63}$/.test(req_id)) {
if (! /^(?:[a-z0-9][a-z0-9\-]{4,63}[a-z0-9]|[a-z0-9]{4,63})$/.test(req_id)) {
var err = new Error('Invalid subdomain. Subdomains must be lowercase and between 4 and 63 alphanumeric characters.');
err.statusCode = 403;
return next(err);
+15
View File
@@ -118,6 +118,21 @@ test('request specific domain', function(done) {
});
});
test('request domain with dash', function(done) {
var opt = {
host: 'http://localhost:' + lt_server_port,
subdomain: 'abcd-1234'
};
localtunnel(test._fake_port, opt, function(err, tunnel) {
assert.ifError(err);
var url = tunnel.url;
assert.ok(new RegExp('^http:\/\/.*localhost:' + lt_server_port + '$').test(url));
test._fake_url = url;
done(err);
});
});
test('request domain that is too long', function(done) {
var opt = {
host: 'http://localhost:' + lt_server_port,