hoelee/server
1
0
Fork 0
Code Issues 76 Pull Requests 13 Actions Packages Projects Releases Wiki Activity

Allows dash characters in subdomains #47

Closed
zackslash wants to merge 2 commits from master into master
pull from: master
merge into: :master
Conversation 1 Commits 2 Files Changed 2
+1003 -2223
zackslash commented 2016-03-02 17:19:03 +00:00 (Migrated from github.com)
Copy Link
Copy Source

localtunnel is a great tool!

There are many valid reasons to use a hyphenated subdomain.
For my use case with Twilio; localtunnel would be perfect if it allowed temporary domains with dashes.

This pull request allows dashes but does not allow a subdomain to start or end with a dash (as per RFC URI syntax spec).

localtunnel is a great tool! There are many valid reasons to use a hyphenated subdomain. For my use case with Twilio; localtunnel would be perfect if it allowed temporary domains with dashes. This pull request allows dashes but does not allow a subdomain to start or end with a dash (as per RFC URI syntax spec).
👍 1
defunctzombie commented 2018-04-02 01:05:53 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Merged via 37df802cc0 (your changes rebased on latest master). Thank you!

Merged via 37df802cc06e9cde69c59085419a6f46db817da5 (your changes rebased on latest master). Thank you!

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
duplicate
enhancement
invalid
question
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
hoelee (Mr hoelee)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: hoelee/server#47