Adding button to deploy to Heroku #165

2021-09-07T17:58:02Z

ViniciusFXavier commented

2021-09-07 17:58:02 +00:00

(Migrated from github.com)

To solve the problem of ports I made a condition to use the ENV PORT value returned by most clounds otherwise use the default port 80.

I currently use this implementation without any problems.

Note: The button will only work when the PR is merged, because the app.json file must be present in the repository.

closes #88 and closes #114

To solve the problem of ports I made a condition to use the ENV `PORT` value returned by most clounds otherwise use the default port 80. I currently use this implementation without any problems. Note: The button will only work when the PR is merged, because the `app.json` file must be present in the repository. closes #88 and closes #114

galmis commented

2022-03-06 14:18:00 +00:00

(Migrated from github.com)

Hi @ViniciusFXavier,

I forked your repo to https://github.com/galmis/localtunnel-server and it does indeed build a localtunnel server instance on heroku, but the server itself does not work as expected.

Your PR doesn't seem to address the issues mentioned in https://github.com/localtunnel/server/issues/88.

Hi @ViniciusFXavier, I forked your repo to https://github.com/galmis/localtunnel-server and it does indeed build a localtunnel server instance on heroku, but the server itself does not work as expected. Your PR doesn't seem to address the issues mentioned in https://github.com/localtunnel/server/issues/88.

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: hoelee/server#165