hoelee/server
1
0
Fork 0
Code Issues 76 Pull Requests 13 Actions Packages Projects Releases Wiki Activity

Add a port pool manager to restrict client ports #134

Open
micoli wants to merge 2 commits from micoli/add_a_port_manager into master
pull from: micoli/add_a_port_manager
merge into: :master
Conversation 10 Commits 2 Files Changed 5
+131 -4
micoli commented 2020-09-30 20:32:57 +00:00 (Migrated from github.com)
Copy Link
Copy Source

this PR to avoid the dynamic attribution of port by net.createServer() but rather by a range specified on the server command line. An internal pool is maintained to distribute ports

this PR to avoid the dynamic attribution of port by `net.createServer()` but rather by a range specified on the server command line. An internal pool is maintained to distribute ports
👍 6
fbricker (Migrated from github.com) approved these changes 2020-12-27 12:58:49 +00:00
fbricker commented 2020-12-27 13:02:14 +00:00 (Migrated from github.com)
Copy Link
Copy Source

hi @defunctzombie Merging this will be amazing!

hi @defunctzombie Merging this will be amazing!
salemgolemugoo commented 2021-01-25 21:33:52 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@defunctzombie could you please merge this one? We can configure firewall after that
#143

@defunctzombie could you please merge this one? We can configure firewall after that #143
defunctzombie commented 2021-01-27 03:29:53 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I don't actively work on this project anymore. @theboroer does some upkeep so its up to him.

I don't actively work on this project anymore. @theboroer does some upkeep so its up to him.
iamkhalidbashir commented 2021-07-30 07:53:21 +00:00 (Migrated from github.com)
Copy Link
Copy Source

this is very important

this is very important
MkLHX commented 2021-08-05 13:50:42 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I don't actively work on this project anymore. @TheBoroer does some upkeep so its up to him.

so please say int on front readme to avoid people thinking this project is not dead anymore....

> > > I don't actively work on this project anymore. @TheBoroer does some upkeep so its up to him. so please say int on front readme to avoid people thinking this project is not dead anymore....
riosje (Migrated from github.com) approved these changes 2022-03-05 03:33:36 +00:00
riosje (Migrated from github.com) left a comment
Copy Link
Copy Source

Looks pretty good.

Looks pretty good.
TheBoroer commented 2022-03-05 04:21:43 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Sorry I've been mia, imma check this out early next week. If its good to go, I'll ping @defunctzombie to give me access to merge it in and push a new version to npm

Sorry I've been mia, imma check this out early next week. If its good to go, I'll ping @defunctzombie to give me access to merge it in and push a new version to npm
dluc commented 2022-03-13 10:36:40 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Hope to see this feature in soon, it would save from opening a huge amount of ports in the firewall

Hope to see this feature in soon, it would save from opening a huge amount of ports in the firewall
luanpontes100 commented 2024-01-05 13:37:45 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I'm using this on my server and something unique happened. I can't say how to recreate this because I'm not able to reproduce myself, but sometimes one URL gives me another client. Let's say I have client1 and client2; sometimes, when I access client1 I'm actually accessing client2, and only normalizes when I restart the server and make the connection again. Do you think this port manager may be the cause?

I'm using this on my server and something unique happened. I can't say how to recreate this because I'm not able to reproduce myself, but sometimes one URL gives me another client. Let's say I have client1 and client2; sometimes, when I access client1 I'm actually accessing client2, and only normalizes when I restart the server and make the connection again. Do you think this port manager may be the cause?
You are not authorized to merge this pull request.
This pull request can be merged automatically.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin micoli/add_a_port_manager:micoli/add_a_port_manager
git checkout micoli/add_a_port_manager
Sign in to join this conversation.
Reviewers
No Reviewers
fbricker
riosje
Labels
Clear labels
bug
duplicate
enhancement
invalid
question
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
hoelee (Mr hoelee)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: hoelee/server#134