subdomain lookup fails when running on localhost #38

New Issue

2015-11-26T10:23:41Z

a7medkamel commented

2015-11-26 10:23:41 +00:00

(Migrated from github.com)

the server uses tldjs to extract subdomains. but tldjs doesn't consider localhost a valid domain; so subdomain lookup fails and proxy calls fallback to the /www page

Looks like we need to add the following line atop server.js

tldjs.validHosts = ['localhost'];

let me know if you have any concerns before I send a pull request.

the server uses tldjs to extract subdomains. but tldjs doesn't consider localhost a valid domain; so subdomain lookup fails and proxy calls fallback to the /www page Looks like we need to add the following line atop server.js ``` javascript tldjs.validHosts = ['localhost']; ``` let me know if you have any concerns before I send a pull request.

defunctzombie commented

2018-04-02 03:05:55 +00:00

(Migrated from github.com)

The server code has been heavily refactored and a new --domain option added for running on non-standard domains or subdomains.

The server code has been heavily refactored and a new _--domain_ option added for running on non-standard domains or subdomains.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: hoelee/server#38