added support multiple-level subdomain #27

2015-05-13T01:21:32Z

chuangbo commented

2015-05-13 01:21:32 +00:00

(Migrated from github.com)

Use full domain like "myproject.tunnel.example.com" as client's id instead of "myproject".

Combine sub_domain and current hostname as client's id when creating new client.
Check the clients object with full hostname when new request comes in.

Use full domain like "myproject.tunnel.example.com" as client's id instead of "myproject". Combine sub_domain and current hostname as client's id when creating new client. Check the clients object with full hostname when new request comes in.

chuangbo commented

2015-05-18 22:49:40 +00:00

(Migrated from github.com)

This pull request added multi-level subdomain support but didn't pass the websocket tests.

I tried to fix, but I found the original master branch cannot pass neither. So I think it's better not to fix websocket support in this pull request.

@defunctzombie what do you think?

This pull request added multi-level subdomain support but didn't pass the websocket tests. I tried to fix, but I found the original master branch cannot pass neither. So I think it's better not to fix websocket support in this pull request. @defunctzombie what do you think?

defunctzombie commented

2017-12-10 16:44:06 +00:00

(Migrated from github.com)

Closing in favor of #65

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: hoelee/server#27