mirror of
https://github.com/cloudflare/cloudflared.git
synced 2025-05-11 21:06:34 +00:00
a6faa0c376
This parameterizes relevant component tests by transport protocol where applicable. The motivation is to have coverage for (graceful or not) shutdown that was broken in QUIC. That logic (as well as reconnect) is different depending on the transport, so we should have it parameterized. In fact, the test is failing for QUIC (and passing for others) right now, which is expected until we roll out some edge fixes for QUIC. So we could have caught this earlier on.
64 lines
2.8 KiB
Python
64 lines
2.8 KiB
Python
#!/usr/bin/env python
|
|
import copy
|
|
import platform
|
|
from time import sleep
|
|
|
|
import pytest
|
|
from flaky import flaky
|
|
|
|
from conftest import CfdModes
|
|
from constants import protocols
|
|
from util import start_cloudflared, wait_tunnel_ready, check_tunnel_not_connected
|
|
|
|
|
|
@flaky(max_runs=3, min_passes=1)
|
|
class TestReconnect:
|
|
default_ha_conns = 4
|
|
default_reconnect_secs = 15
|
|
extra_config = {
|
|
"stdin-control": True,
|
|
}
|
|
|
|
def _extra_config(self, protocol):
|
|
return {
|
|
"stdin-control": True,
|
|
"protocol": protocol,
|
|
}
|
|
|
|
@pytest.mark.skipif(platform.system() == "Windows", reason=f"Currently buggy on Windows TUN-4584")
|
|
@pytest.mark.parametrize("protocol", protocols())
|
|
def test_named_reconnect(self, tmp_path, component_tests_config, protocol):
|
|
config = component_tests_config(self._extra_config(protocol))
|
|
with start_cloudflared(tmp_path, config, new_process=True, allow_input=True, capture_output=False) as cloudflared:
|
|
# Repeat the test multiple times because some issues only occur after multiple reconnects
|
|
self.assert_reconnect(config, cloudflared, 5)
|
|
|
|
def test_classic_reconnect(self, tmp_path, component_tests_config):
|
|
extra_config = copy.copy(self.extra_config)
|
|
extra_config["hello-world"] = True
|
|
config = component_tests_config(additional_config=extra_config, cfd_mode=CfdModes.CLASSIC)
|
|
with start_cloudflared(tmp_path, config, cfd_args=[], new_process=True, allow_input=True, capture_output=False) as cloudflared:
|
|
self.assert_reconnect(config, cloudflared, 1)
|
|
|
|
def send_reconnect(self, cloudflared, secs):
|
|
# Although it is recommended to use the Popen.communicate method, we cannot
|
|
# use it because it blocks on reading stdout and stderr until EOF is reached
|
|
cloudflared.stdin.write(f"reconnect {secs}s\n".encode())
|
|
cloudflared.stdin.flush()
|
|
|
|
def assert_reconnect(self, config, cloudflared, repeat):
|
|
wait_tunnel_ready(tunnel_url=config.get_url(), require_min_connections=self.default_ha_conns)
|
|
for _ in range(repeat):
|
|
for i in range(self.default_ha_conns):
|
|
self.send_reconnect(cloudflared, self.default_reconnect_secs)
|
|
expect_connections = self.default_ha_conns-i-1
|
|
if expect_connections > 0:
|
|
# Don't check if tunnel returns 200 here because there is a race condition between wait_tunnel_ready
|
|
# retrying to get 200 response and reconnecting
|
|
wait_tunnel_ready(require_min_connections=expect_connections)
|
|
else:
|
|
check_tunnel_not_connected()
|
|
|
|
sleep(self.default_reconnect_secs * 2)
|
|
wait_tunnel_ready(tunnel_url=config.get_url(), require_min_connections=self.default_ha_conns)
|