From 29197d241a364b6c5a0139b51af7710097bb9562 Mon Sep 17 00:00:00 2001 From: tcely Date: Fri, 21 Feb 2025 05:01:29 -0500 Subject: [PATCH 1/2] Remove duplicate function --- tubesync/sync/views.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/tubesync/sync/views.py b/tubesync/sync/views.py index 3770ab75..1035ffcd 100644 --- a/tubesync/sync/views.py +++ b/tubesync/sync/views.py @@ -818,9 +818,6 @@ class CompletedTasksView(ListView): self.filter_source = None return super().dispatch(request, *args, **kwargs) - def get_queryset(self): - return CompletedTask.objects.all().order_by('-run_at') - def get_queryset(self): if self.filter_source: q = CompletedTask.objects.filter(queue=str(self.filter_source.pk)) From e727e30ecea7b38cdd242db086c2589ff37b9ee7 Mon Sep 17 00:00:00 2001 From: tcely Date: Fri, 21 Feb 2025 05:18:00 -0500 Subject: [PATCH 2/2] Simplify the `get_queryset` function --- tubesync/sync/views.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tubesync/sync/views.py b/tubesync/sync/views.py index 1035ffcd..2a9ce8b5 100644 --- a/tubesync/sync/views.py +++ b/tubesync/sync/views.py @@ -819,10 +819,9 @@ class CompletedTasksView(ListView): return super().dispatch(request, *args, **kwargs) def get_queryset(self): + q = CompletedTask.objects.all() if self.filter_source: - q = CompletedTask.objects.filter(queue=str(self.filter_source.pk)) - else: - q = CompletedTask.objects.all() + q = q.filter(queue=str(self.filter_source.pk)) return q.order_by('-run_at') def get_context_data(self, *args, **kwargs):