From 686cb75967b2092d0b2a8a039521c2ac5cd8be74 Mon Sep 17 00:00:00 2001 From: lwthiker Date: Sat, 16 Sep 2023 09:09:00 +0300 Subject: [PATCH] Remove --false-start flag Remove the --false-start flag completely. In the Chrome version it has no affect, and in the Firefox version it may cause connection errors. This flag doesn't seem to affect TLS or HTTP signatures so is safe to remove. The flag seems to cause connection errors with some http/2 servers. The server chooses http/2 based on alpn but curl initiates a http/1.1 connection instead. This is an upstream bug in curl that affects us as well. --- chrome/curl_chrome100 | 2 +- chrome/curl_chrome101 | 2 +- chrome/curl_chrome104 | 2 +- chrome/curl_chrome107 | 2 +- chrome/curl_chrome110 | 2 +- chrome/curl_chrome116 | 2 +- chrome/curl_chrome99 | 2 +- chrome/curl_chrome99_android | 2 +- chrome/curl_edge101 | 2 +- chrome/curl_edge99 | 2 +- chrome/curl_safari15_3 | 2 +- chrome/curl_safari15_5 | 2 +- docs/02_USAGE.md | 2 +- firefox/curl_ff100 | 2 +- firefox/curl_ff102 | 2 +- firefox/curl_ff109 | 2 +- firefox/curl_ff117 | 2 +- firefox/curl_ff91esr | 2 +- firefox/curl_ff95 | 2 +- firefox/curl_ff98 | 2 +- 20 files changed, 20 insertions(+), 20 deletions(-) diff --git a/chrome/curl_chrome100 b/chrome/curl_chrome100 index 045aace..838df3e 100755 --- a/chrome/curl_chrome100 +++ b/chrome/curl_chrome100 @@ -20,7 +20,7 @@ dir=${0%/*} -H 'Sec-Fetch-Dest: document' \ -H 'Accept-Encoding: gzip, deflate, br' \ -H 'Accept-Language: en-US,en;q=0.9' \ - --http2 --false-start --compressed \ + --http2 --compressed \ --tlsv1.2 --alps \ --cert-compression brotli \ "$@" diff --git a/chrome/curl_chrome101 b/chrome/curl_chrome101 index a0b1855..5723a67 100755 --- a/chrome/curl_chrome101 +++ b/chrome/curl_chrome101 @@ -20,7 +20,7 @@ dir=${0%/*} -H 'Sec-Fetch-Dest: document' \ -H 'Accept-Encoding: gzip, deflate, br' \ -H 'Accept-Language: en-US,en;q=0.9' \ - --http2 --false-start --compressed \ + --http2 --compressed \ --tlsv1.2 --alps \ --cert-compression brotli \ "$@" diff --git a/chrome/curl_chrome104 b/chrome/curl_chrome104 index 1868e82..5ed6c88 100755 --- a/chrome/curl_chrome104 +++ b/chrome/curl_chrome104 @@ -20,7 +20,7 @@ dir=${0%/*} -H 'Sec-Fetch-Dest: document' \ -H 'Accept-Encoding: gzip, deflate, br' \ -H 'Accept-Language: en-US,en;q=0.9' \ - --http2 --false-start --compressed \ + --http2 --compressed \ --tlsv1.2 --alps \ --cert-compression brotli \ "$@" diff --git a/chrome/curl_chrome107 b/chrome/curl_chrome107 index 2c6153e..a270306 100755 --- a/chrome/curl_chrome107 +++ b/chrome/curl_chrome107 @@ -20,7 +20,7 @@ dir=${0%/*} -H 'Sec-Fetch-Dest: document' \ -H 'Accept-Encoding: gzip, deflate, br' \ -H 'Accept-Language: en-US,en;q=0.9' \ - --http2 --http2-no-server-push --false-start --compressed \ + --http2 --http2-no-server-push --compressed \ --tlsv1.2 --alps \ --cert-compression brotli \ "$@" diff --git a/chrome/curl_chrome110 b/chrome/curl_chrome110 index 5887096..0cffa77 100755 --- a/chrome/curl_chrome110 +++ b/chrome/curl_chrome110 @@ -20,7 +20,7 @@ dir=${0%/*} -H 'Sec-Fetch-Dest: document' \ -H 'Accept-Encoding: gzip, deflate, br' \ -H 'Accept-Language: en-US,en;q=0.9' \ - --http2 --http2-no-server-push --false-start --compressed \ + --http2 --http2-no-server-push --compressed \ --tlsv1.2 --alps --tls-permute-extensions \ --cert-compression brotli \ "$@" diff --git a/chrome/curl_chrome116 b/chrome/curl_chrome116 index dcdf0bf..1ae469a 100755 --- a/chrome/curl_chrome116 +++ b/chrome/curl_chrome116 @@ -20,7 +20,7 @@ dir=${0%/*} -H 'Sec-Fetch-Dest: document' \ -H 'Accept-Encoding: gzip, deflate, br' \ -H 'Accept-Language: en-US,en;q=0.9' \ - --http2 --http2-no-server-push --false-start --compressed \ + --http2 --http2-no-server-push --compressed \ --tlsv1.2 --alps --tls-permute-extensions \ --cert-compression brotli \ "$@" diff --git a/chrome/curl_chrome99 b/chrome/curl_chrome99 index 2341b60..0b3ed7e 100755 --- a/chrome/curl_chrome99 +++ b/chrome/curl_chrome99 @@ -20,7 +20,7 @@ dir=${0%/*} -H 'Sec-Fetch-Dest: document' \ -H 'Accept-Encoding: gzip, deflate, br' \ -H 'Accept-Language: en-US,en;q=0.9' \ - --http2 --false-start --compressed \ + --http2 --compressed \ --tlsv1.2 --alps \ --cert-compression brotli \ "$@" diff --git a/chrome/curl_chrome99_android b/chrome/curl_chrome99_android index 2e7a4c8..b36d1aa 100755 --- a/chrome/curl_chrome99_android +++ b/chrome/curl_chrome99_android @@ -20,7 +20,7 @@ dir=${0%/*} -H 'Sec-Fetch-Dest: document' \ -H 'Accept-Encoding: gzip, deflate, br' \ -H 'Accept-Language: en-US,en;q=0.9' \ - --http2 --false-start --compressed \ + --http2 --compressed \ --tlsv1.2 --alps \ --cert-compression brotli \ "$@" diff --git a/chrome/curl_edge101 b/chrome/curl_edge101 index d69ee5c..35e040a 100755 --- a/chrome/curl_edge101 +++ b/chrome/curl_edge101 @@ -20,7 +20,7 @@ dir=${0%/*} -H 'Sec-Fetch-Dest: document' \ -H 'Accept-Encoding: gzip, deflate, br' \ -H 'Accept-Language: en-US,en;q=0.9' \ - --http2 --false-start --compressed \ + --http2 --compressed \ --tlsv1.2 --alps \ --cert-compression brotli \ "$@" diff --git a/chrome/curl_edge99 b/chrome/curl_edge99 index f4b3b3f..4869bd8 100755 --- a/chrome/curl_edge99 +++ b/chrome/curl_edge99 @@ -20,7 +20,7 @@ dir=${0%/*} -H 'Sec-Fetch-Dest: document' \ -H 'Accept-Encoding: gzip, deflate, br' \ -H 'Accept-Language: en-US,en;q=0.9' \ - --http2 --false-start --compressed \ + --http2 --compressed \ --tlsv1.2 --alps \ --cert-compression brotli \ "$@" diff --git a/chrome/curl_safari15_3 b/chrome/curl_safari15_3 index 5821758..b22af9b 100755 --- a/chrome/curl_safari15_3 +++ b/chrome/curl_safari15_3 @@ -14,7 +14,7 @@ dir=${0%/*} -H 'Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8' \ -H 'Accept-Language: en-us' \ -H 'Accept-Encoding: gzip, deflate, br' \ - --http2 --false-start --compressed \ + --http2 --compressed \ --tlsv1.0 --no-tls-session-ticket \ --http2-pseudo-headers-order 'mspa' \ "$@" diff --git a/chrome/curl_safari15_5 b/chrome/curl_safari15_5 index 8b6ebf4..a541e77 100755 --- a/chrome/curl_safari15_5 +++ b/chrome/curl_safari15_5 @@ -14,7 +14,7 @@ dir=${0%/*} -H 'Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8' \ -H 'Accept-Language: en-GB,en-US;q=0.9,en;q=0.8' \ -H 'Accept-Encoding: gzip, deflate, br' \ - --http2 --false-start --compressed \ + --http2 --compressed \ --tlsv1.0 --no-tls-session-ticket \ --cert-compression zlib \ --http2-pseudo-headers-order 'mspa' \ diff --git a/docs/02_USAGE.md b/docs/02_USAGE.md index 45f8c75..e59c73e 100644 --- a/docs/02_USAGE.md +++ b/docs/02_USAGE.md @@ -50,7 +50,7 @@ The important part of the script is: -H 'Sec-Fetch-Dest: document' \ -H 'Accept-Encoding: gzip, deflate, br' \ -H 'Accept-Language: en-US,en;q=0.9' \ - --http2 --false-start --compressed \ + --http2 --compressed \ --tlsv1.2 --no-npn --alps \ --cert-compression brotli \ "$@" diff --git a/firefox/curl_ff100 b/firefox/curl_ff100 index cf740eb..0ebff7b 100755 --- a/firefox/curl_ff100 +++ b/firefox/curl_ff100 @@ -18,5 +18,5 @@ dir=${0%/*} -H 'Sec-Fetch-Site: none' \ -H 'Sec-Fetch-User: ?1' \ -H 'TE: Trailers' \ - --http2 --false-start --compressed \ + --http2 --compressed \ "$@" diff --git a/firefox/curl_ff102 b/firefox/curl_ff102 index c810652..af46503 100755 --- a/firefox/curl_ff102 +++ b/firefox/curl_ff102 @@ -18,5 +18,5 @@ dir=${0%/*} -H 'Sec-Fetch-Site: none' \ -H 'Sec-Fetch-User: ?1' \ -H 'TE: Trailers' \ - --http2 --false-start --compressed \ + --http2 --compressed \ "$@" diff --git a/firefox/curl_ff109 b/firefox/curl_ff109 index be086c1..3f782ab 100755 --- a/firefox/curl_ff109 +++ b/firefox/curl_ff109 @@ -18,5 +18,5 @@ dir=${0%/*} -H 'Sec-Fetch-Site: none' \ -H 'Sec-Fetch-User: ?1' \ -H 'TE: Trailers' \ - --http2 --false-start --compressed \ + --http2 --compressed \ "$@" diff --git a/firefox/curl_ff117 b/firefox/curl_ff117 index 84b4528..91c3e6a 100755 --- a/firefox/curl_ff117 +++ b/firefox/curl_ff117 @@ -18,5 +18,5 @@ dir=${0%/*} -H 'Sec-Fetch-Site: none' \ -H 'Sec-Fetch-User: ?1' \ -H 'TE: Trailers' \ - --http2 --false-start --compressed \ + --http2 --compressed \ "$@" diff --git a/firefox/curl_ff91esr b/firefox/curl_ff91esr index 7520c74..ec0ba47 100755 --- a/firefox/curl_ff91esr +++ b/firefox/curl_ff91esr @@ -18,5 +18,5 @@ dir=${0%/*} -H 'Sec-Fetch-Site: none' \ -H 'Sec-Fetch-User: ?1' \ -H 'TE: Trailers' \ - --http2 --false-start --compressed \ + --http2 --compressed \ "$@" diff --git a/firefox/curl_ff95 b/firefox/curl_ff95 index bf11f90..e9c9489 100755 --- a/firefox/curl_ff95 +++ b/firefox/curl_ff95 @@ -18,5 +18,5 @@ dir=${0%/*} -H 'Sec-Fetch-Site: none' \ -H 'Sec-Fetch-User: ?1' \ -H 'TE: Trailers' \ - --http2 --false-start --compressed \ + --http2 --compressed \ "$@" diff --git a/firefox/curl_ff98 b/firefox/curl_ff98 index c49cfcb..c8fcc68 100755 --- a/firefox/curl_ff98 +++ b/firefox/curl_ff98 @@ -18,5 +18,5 @@ dir=${0%/*} -H 'Sec-Fetch-Site: none' \ -H 'Sec-Fetch-User: ?1' \ -H 'TE: Trailers' \ - --http2 --false-start --compressed \ + --http2 --compressed \ "$@"