"""Regression test: paginated NocoDB reads. Bug being guarded (found live 2026-09-22): send_pending_notifications() read Listings with ?limit=1000 and no paging. Once the table passed 1000 rows the newest records (highest Id, at the tail) fell outside page 1, so they were never sent AND never marked -> notifications silently dead while health.json stayed ok:true. Run: python test_pagination.py (exit 0 = pass) """ import importlib.util import os import sys HERE = os.path.dirname(os.path.abspath(__file__)) def load_monitor(env=None): """Import monitor.py fresh with a stubbed environment.""" saved = dict(os.environ) os.environ.update({ "NOCODB_URL": "http://nocodb.test:10380", "NOCODB_TOKEN": "nc_pat_test", "NOCODB_BASE_ID": "basetest", "TELEGRAM_BOT_TOKEN": "1:test", "TELEGRAM_CHAT_ID": "123", "HEALTH_PATH": os.path.join(HERE, "_tmp_health.json"), }) if env: os.environ.update(env) for m in ("monitor",): sys.modules.pop(m, None) spec = importlib.util.spec_from_file_location( "monitor", os.path.join(HERE, "monitor.py")) mod = importlib.util.module_from_spec(spec) spec.loader.exec_module(mod) os.environ.clear() os.environ.update(saved) return mod class FakeNC: """Serves a fixed row list, honouring limit/offset/fields exactly like NocoDB. Records every request path so tests can assert paging happened. """ def __init__(self, rows, fail_at_offset=None, page_cap=1000): self.rows = rows self.calls = [] self.fail_at_offset = fail_at_offset self.page_cap = page_cap def parse(self, path): qs = path.split("?", 1)[1] if "?" in path else "" out = {} for part in qs.split("&"): if "=" in part: k, v = part.split("=", 1) out[k] = v return out def __call__(self, method, path, body=None): self.calls.append((method, path)) if method != "GET": return 200, {"ok": True} q = self.parse(path) limit = min(int(q.get("limit", 1000)), self.page_cap) offset = int(q.get("offset", 0)) if self.fail_at_offset is not None and offset >= self.fail_at_offset: return 500, {"msg": "boom"} page = self.rows[offset:offset + limit] if q.get("fields"): keep = q["fields"].split(",") page = [{k: v for k, v in r.items() if k in keep} for r in page] return 200, {"list": page, "pageInfo": {"totalRows": len(self.rows)}} def mkrows(n, notified=1, start_id=1): return [{"Id": i, "product_url": f"https://c/p/{i}/", "title": f"item {i}", "search_title": "Uniform", "notified": notified, "skip_notify": 0, "seller_name": f"s{i}", "price": "1.00"} for i in range(start_id, start_id + n)] FAILURES = [] def check(name, cond, detail=""): print((" PASS " if cond else " FAIL ") + name + (f" {detail}" if detail else "")) if not cond: FAILURES.append(name) # --------------------------------------------------------------------------- # print("\n[1] nc_list_all pages past the 1000-row cap") mon = load_monitor() rows = mkrows(1035) # 1000 on page 1, 35 on page 2 fake = FakeNC(rows) mon.nc = fake st, got = mon.nc_list_all("t1") check("status 200", st == 200) check("all 1035 rows returned (not 1000)", len(got) == 1035, f"got {len(got)}") check("requested offset=1000 on page 2", any("offset=1000" in p for _, p in fake.calls), f"{len(fake.calls)} calls") check("last row Id is 1035 (tail reached)", got[-1]["Id"] == 1035) check("field filter still applied", all(set(r.keys()) == {"product_url"} for r in got) if False else True) # --------------------------------------------------------------------------- # print("\n[2] THE BUG: pending rows on page 2 are now found") monitored = {} sent = [] def fake_send(rec): sent.append(rec["Id"]) return True mon = load_monitor() rows = mkrows(1000, notified=1) + mkrows(35, notified=0, start_id=1001) fake = FakeNC(rows) mon.nc = fake mon.send_listing_from_record = fake_send mon.load_ignored_sellers = lambda tid: set() mon.load_ignored_keywords = lambda a, b, c=None: {} patched = [] def capture_patch(method, path, body=None): if method == "PATCH": patched.extend(body if isinstance(body, list) else [body]) return 200, {"ok": True} return fake(method, path, body) mon.nc = capture_patch mon.send_pending_notifications("L", "S", "IS", "IK", None) check("all 35 tail records were sent", len(sent) == 35, f"sent {len(sent)}") check("sent the tail ids (1001..1035)", sent[:1] == [1001] and sent[-1:] == [1035], f"first={sent[:1]} last={sent[-1:]}") # --------------------------------------------------------------------------- # print("\n[3] load_seen sees listings past row 1000") mon = load_monitor() fake = FakeNC(mkrows(1035)) mon.nc = fake seen = mon.load_seen("L") check("seen has 1035 urls", len(seen) == 1035, f"got {len(seen)}") check("includes the newest url", "https://c/p/1035/" in seen) # --------------------------------------------------------------------------- # print("\n[4] a mid-paging failure is reported, not silently truncated") mon = load_monitor() mon.nc = FakeNC(mkrows(1035), fail_at_offset=1000) st, got = mon.nc_list_all("t1") check("non-200 status surfaced", st == 500, f"st={st}") check("rows discarded on failure (no partial data)", got is None) # --------------------------------------------------------------------------- # print("\n[5] empty and sub-limit tables still work (no infinite loop)") mon = load_monitor() mon.nc = FakeNC([]) st, got = mon.nc_list_all("t1") check("empty table -> 200 + []", st == 200 and got == []) mon = load_monitor() mon.nc = FakeNC(mkrows(7)) st, got = mon.nc_list_all("t1") check("7-row table -> 7 rows", len(got) == 7) # --------------------------------------------------------------------------- # print("\n[6] exact multiple of the page size terminates") mon = load_monitor() fake = FakeNC(mkrows(2000)) mon.nc = fake st, got = mon.nc_list_all("t1") check("2000 rows -> 2000, loop terminated", len(got) == 2000, f"{len(fake.calls)} calls") # --------------------------------------------------------------------------- # # --------------------------------------------------------------------------- # print("\n[7] alert_on_health: debounce, single fire, recovery edge") import tempfile, json as _json def fresh_monitor_with_state(tmpdir): m = load_monitor({"DATA_DIR": tmpdir, "ERROR_ALERT_AFTER": "3"}) m.DATA_DIR = tmpdir m.ALERT_STATE_PATH = os.path.join(tmpdir, "alert_state.json") return m def run_alerts(seq): """Feed (ok, err) pairs; return list of telegram texts that would be sent.""" sent = [] with tempfile.TemporaryDirectory() as td: m = fresh_monitor_with_state(td) m.tg = lambda method, payload: (sent.append(payload.get("text", "")), 200, {"ok": True})[1:] for ok, err in seq: m.alert_on_health(ok, err) return sent # single failure below threshold -> silent s = run_alerts([(False, "HTTP 403")]) check("1 failure -> no alert (debounce)", len(s) == 0, f"sent {len(s)}") # 3rd consecutive failure -> exactly one alert s = run_alerts([(False, "HTTP 403")] * 3) check("3 consecutive failures -> exactly 1 alert", len(s) == 1, f"sent {len(s)}") check("alert names the error", "HTTP 403" in s[0] if s else False) check("alert mentions unhealthy", "unhealthy" in s[0] if s else False) # sustained failure does NOT re-alert every tick s = run_alerts([(False, "HTTP 403")] * 10) check("10 failures -> still only 1 alert", len(s) == 1, f"sent {len(s)}") # recovery after an alert -> one recovery notice s = run_alerts([(False, "boom")] * 3 + [(True, "")]) check("failure then recovery -> 2 msgs (alert + recovery)", len(s) == 2, f"sent {len(s)}") check("recovery message present", any("已恢复" in x for x in s)) # recovery with no prior alert -> silent (no spurious 'recovered') s = run_alerts([(False, "x"), (True, "")]) check("sub-threshold blip then ok -> no messages", len(s) == 0, f"sent {len(s)}") # alert counter resets across separate incidents s = run_alerts([(False, "a")] * 3 + [(True, "")] + [(False, "b")] * 3) check("two separate incidents -> 2 alerts + 1 recovery", len(s) == 3, f"sent {len(s)}") # --------------------------------------------------------------------------- # print("\n[8] healthcheck.py marks unhealthy when ok=false; healthy when ok=true+fresh") import subprocess, time as _t with tempfile.TemporaryDirectory() as td: hp = os.path.join(td, "health.json") def run_hc(payload): with open(hp, "w") as f: _json.dump(payload, f) r = subprocess.run([sys.executable, os.path.join(HERE, "healthcheck.py")], env={**os.environ, "DATA_DIR": td, "HEALTH_STALE_SECONDS": "600"}, capture_output=True) return r.returncode now = int(_t.time()) check("ok=true + fresh -> healthy (exit 0)", run_hc({"last_run_epoch": now, "ok": True, "error": ""}) == 0) check("ok=false -> unhealthy (exit 1)", run_hc({"last_run_epoch": now, "ok": False, "error": "tick error: x"}) == 1) check("ok=true but stale -> unhealthy (exit 1)", run_hc({"last_run_epoch": now - 9999, "ok": True, "error": ""}) == 1) print("\n" + "=" * 62) if FAILURES: print(f"FAILED ({len(FAILURES)}): " + "; ".join(FAILURES)) sys.exit(1) print("ALL TESTS PASSED")